Parcourir la source

Fixed missing cache flush in lfs_migrate

The data written to the prog cache would make littlefs internally
consistent, but because this was never written to disk, the filesystem
would become unmountable.

Unfortunately, this wasn't found during testing because caches automatically
flush if data is written up to a program boundary (maybe this was a mistake?).

Found by rojer
Christopher Haster il y a 6 ans
Parent
commit
36973d8fd5
1 fichiers modifiés avec 5 ajouts et 0 suppressions
  1. 5 0
      lfs.c

+ 5 - 0
lfs.c

@@ -4399,6 +4399,11 @@ int lfs_migrate(lfs_t *lfs, const struct lfs_config *cfg) {
                     goto cleanup;
                 }
             }
+
+            err = lfs_bd_flush(lfs, &lfs->pcache, &lfs->rcache, true);
+            if (err) {
+                goto cleanup;
+            }
         }
 
         // Create new superblock. This marks a successful migration!